revert(amazonq): hide java 21 option #5354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 10, 2025 15:44
ntarakad-aws
approved these changes
Feb 11, 2025
| codemodernizer.chat.message.button.view_summary=View summary | ||
| codemodernizer.chat.message.changes_applied=I applied the changes to your project. | ||
| codemodernizer.chat.message.choose_objective=I can help you with the following tasks:\n- Upgrade your Java 8, Java 11, and Java 17 codebases to Java 17 or Java 21.\n- Upgrade Java 17 or Java 21 code with up-to-date libraries and other dependencies.\n- Convert embedded SQL code for Oracle to PostgreSQL database migrations in AWS DMS.\n\nWhat would you like to do? You can enter "language upgrade" or "sql conversion". | ||
| codemodernizer.chat.message.choose_objective=I can help you with the following tasks:\n- Upgrade your Java 8 and Java 11 codebases to Java 17.\n- Upgrade Java 17 code with up-to-date libraries and other dependencies.\n- Convert embedded SQL code for Oracle to PostgreSQL database migrations in AWS DMS.\n\nWhat would you like to do? You can enter "language upgrade" or "sql conversion". |
Contributor
There was a problem hiding this comment.
Not sure what it was before 21 was added for messaging, but did we have upgrade your java 8, 11 and 17 or did it just say 8 and 11?
Contributor
Author
There was a problem hiding this comment.
I think "8, 11, and 17", but the way I have it here is also fine since the second bullet point says "Upgrade Java 17 code with up-to-date libraries and other dependencies"
manodnyab
approved these changes
Feb 11, 2025
dhasani23
added a commit
that referenced
this pull request
Feb 11, 2025
This reverts commit 9a60e50.
dhasani23
added a commit
that referenced
this pull request
Feb 11, 2025
samgst-amazon
pushed a commit
that referenced
this pull request
Feb 12, 2025
* revert(amazonq): hide java 21 option * remove unused import * update String --------- Co-authored-by: David Hasani <[email protected]>
samgst-amazon
pushed a commit
that referenced
this pull request
Feb 12, 2025
gandhi-21
pushed a commit
to gandhi-21/aws-toolkit-jetbrains
that referenced
this pull request
Feb 26, 2025
* revert(amazonq): hide java 21 option * remove unused import * update String --------- Co-authored-by: David Hasani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Hide Java 21 support due to an emergency release in JB.
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.